Make liblzma an optional dependency. #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is only used when extracting binaries from the zonky repo which is already behind a feature flag. See also theseus-rs#187 for an xplanation of why this cause issues when a project also pulls in the xz2 crate (can't link the lzma C library twice). Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
gz
added a commit
to feldera/feldera
that referenced
this pull request
Jun 15, 2025
- pg-embed isn't really maintained anymore, and this one is. - Another reason is that this one happens to have binaries with the right alignment for ELF files for our new ARM CI machines (which have a 64KB default page-size), whereas ones from pg-embed align ELF section to 4K so our machines refuse to load them. - Another nice thing is that this one has a 'bundle' feature so we don't need the pre-install step anymore, so I removed it. We still need a fork sadly but I made a PR for them which will hopefully go in: theseus-rs/postgresql-embedded#188 Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
gz
added a commit
to feldera/feldera
that referenced
this pull request
Jun 15, 2025
- pg-embed isn't really maintained anymore, and this one is. - Another reason is that this one happens to have binaries with the right alignment for ELF files for our new ARM CI machines (which have a 64KB default page-size), whereas ones from pg-embed align ELF section to 4K so our machines refuse to load them. - Another nice thing is that this one has a 'bundle' feature so we don't need the pre-install step anymore, so I removed it. We still need a fork sadly but I made a PR for them which will hopefully go in: theseus-rs/postgresql-embedded#188 Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
github-merge-queue bot
pushed a commit
to feldera/feldera
that referenced
this pull request
Jun 15, 2025
- pg-embed isn't really maintained anymore, and this one is. - Another reason is that this one happens to have binaries with the right alignment for ELF files for our new ARM CI machines (which have a 64KB default page-size), whereas ones from pg-embed align ELF section to 4K so our machines refuse to load them. - Another nice thing is that this one has a 'bundle' feature so we don't need the pre-install step anymore, so I removed it. We still need a fork sadly but I made a PR for them which will hopefully go in: theseus-rs/postgresql-embedded#188 Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
gz
added a commit
to feldera/feldera
that referenced
this pull request
Jun 15, 2025
- pg-embed isn't really maintained anymore, and this one is. - Another reason is that this one happens to have binaries with the right alignment for ELF files for our new ARM CI machines (which have a 64KB default page-size), whereas ones from pg-embed align ELF section to 4K so our machines refuse to load them. - Another nice thing is that this one has a 'bundle' feature so we don't need the pre-install step anymore, so I removed it. We still need a fork sadly but I made a PR for them which will hopefully go in: theseus-rs/postgresql-embedded#188 Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
github-merge-queue bot
pushed a commit
to feldera/feldera
that referenced
this pull request
Jun 15, 2025
- pg-embed isn't really maintained anymore, and this one is. - Another reason is that this one happens to have binaries with the right alignment for ELF files for our new ARM CI machines (which have a 64KB default page-size), whereas ones from pg-embed align ELF section to 4K so our machines refuse to load them. - Another nice thing is that this one has a 'bundle' feature so we don't need the pre-install step anymore, so I removed it. We still need a fork sadly but I made a PR for them which will hopefully go in: theseus-rs/postgresql-embedded#188 Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Otherwise, I don't think the changes from env variable get picked up. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage 98.44% 98.44%
=======================================
Files 75 75
Lines 10181 10181
=======================================
Hits 10023 10023
Misses 158 158 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brianheineman
approved these changes
Jun 17, 2025
|
@gz thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is only used when extracting binaries from the zonky repo which is already behind a feature flag.
See also #187 for an xplanation of why this cause issues when a project also pulls in the xz2 crate (can't link the lzma C library twice).