Feature branch#1
Closed
EllieJudge wants to merge 8 commits into
maintechreturners/javascript-refactoring-exercise:mainfrom
feature-branchtechreturners/javascript-refactoring-exercise:feature-branchCopy head branch name to clipboard
Closed
Feature branch#1EllieJudge wants to merge 8 commits intomaintechreturners/javascript-refactoring-exercise:mainfrom feature-branchtechreturners/javascript-refactoring-exercise:feature-branchCopy head branch name to clipboard
EllieJudge wants to merge 8 commits into
maintechreturners/javascript-refactoring-exercise:mainfrom
feature-branchtechreturners/javascript-refactoring-exercise:feature-branchCopy head branch name to clipboard
Conversation
eggsy84
reviewed
Sep 28, 2021
eggsy84
reviewed
Sep 28, 2021
eggsy84
reviewed
Sep 28, 2021
eggsy84
reviewed
Sep 28, 2021
eggsy84
reviewed
Sep 28, 2021
eggsy84
requested changes
Sep 28, 2021
eggsy84
left a comment
Contributor
There was a problem hiding this comment.
Thanks for sending over @EllieJudge
I've dropped a few comments and suggested changes before merging
|
Hi @EllieJudge - PR looks good :) Same as @eggsy84 's comments :) Not for this PR but have you thought about an activity where things are taken up a notch? e.g. translating ES5 classes to ES6 classes? https://medium.com/@apalshah/javascript-class-difference-between-es5-and-es6-classes-a37b6c90c7f8 - do you think this would be something that the learners will find helpful? |
Contributor
|
Hey @EllieJudge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds old fashioned JS for learners to refactor