Runtime error in permissions_endpoint#513
Merged
t8y8 merged 4 commits intotableau:developmenttableau/server-client-python:developmentfrom Nov 4, 2019
Merged
Runtime error in permissions_endpoint#513t8y8 merged 4 commits intotableau:developmenttableau/server-client-python:developmentfrom
t8y8 merged 4 commits intotableau:developmenttableau/server-client-python:developmentfrom
Conversation
Release v0.9 ## 0.9 (4 Oct 2019) * Added Metadata API endpoints (tableau#431) * Added site settings for Data Catalog and Prep Conductor (tableau#434) * Added new fields to ViewItem (tableau#331) * Added support and samples for Tableau Server Personal Access Tokens (tableau#465) * Added Permissions endpoints (tableau#429) * Added tags to ViewItem (tableau#470) * Added Databases and Tables endpoints (tableau#445) * Added Flow endpoints (tableau#494) * Added ability to filter projects by topLevelProject attribute (tableau#497) * Improved server_info endpoint error handling (tableau#439) * Improved Pager to take in keyword arguments (tableau#451) * Fixed UUID serialization error while publishing workbook (tableau#449) * Fixed materalized views in request body for update_workbook (tableau#461)
Runtime error: grantee.permissions_grantee_type replaced with grantee.tag_name in the permissions_endpoint delete method.
Runtime error in default_permissions_endpoint.py method delete_default_permission
t8y8
suggested changes
Oct 23, 2019
Collaborator
t8y8
left a comment
There was a problem hiding this comment.
The changes themselves look good.
Can you please do the following:
- Move this to be against the development branch
- Fix the linting failure, it looks like line indentation mismatches
- Make sure you've signed the CLA.
Contributor
Author
|
Apologies for the delay. I've actioned those three items. |
Collaborator
|
Merged! Thanks for the fix! |
|
Great! You're welcome. When do we expect this to make it into the master branch and released? |
shinchris
pushed a commit
that referenced
this pull request
Feb 21, 2020
* Added a way to handle non-xml errors (#515) * Added Webhooks endpoints for create, delete, get, list, and test (#523, #532) * Added delete method in the tasks endpoint (#524) * Added description attribute to WorkbookItem (#533) * Added support for materializeViews as schedule and task types (#542) * Added warnings to schedules (#550, #551) * Added ability to update parent_id attribute of projects (#560, #567) * Improved filename behavior for download endpoints (#517) * Improved logging (#508) * Fixed runtime error in permissions endpoint (#513) * Fixed move_workbook_sites sample (#503) * Fixed project permissions endpoints (#527) * Fixed login.py sample to accept site name (#549)
shinchris
pushed a commit
that referenced
this pull request
Feb 21, 2020
Merging v0.10 changes from development to master * Added a way to handle non-xml errors (#515) * Added Webhooks endpoints for create, delete, get, list, and test (#523, #532) * Added delete method in the tasks endpoint (#524) * Added description attribute to WorkbookItem (#533) * Added support for materializeViews as schedule and task types (#542) * Added warnings to schedules (#550, #551) * Added ability to update parent_id attribute of projects (#560, #567) * Improved filename behavior for download endpoints (#517) * Improved logging (#508) * Fixed runtime error in permissions endpoint (#513) * Fixed move_workbook_sites sample (#503) * Fixed project permissions endpoints (#527) * Fixed login.py sample to accept site name (#549)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime error: grantee.permissions_grantee_type replaced with grantee.tag_name in the permissions_endpoint delete method.