Close missing brackets in log texts#508
Merged
t8y8 merged 2 commits intotableau:developmenttableau/server-client-python:developmentfrom Nov 5, 2019
Merged
Close missing brackets in log texts#508t8y8 merged 2 commits intotableau:developmenttableau/server-client-python:developmentfrom
t8y8 merged 2 commits intotableau:developmenttableau/server-client-python:developmentfrom
Conversation
t8y8
suggested changes
Oct 7, 2019
Collaborator
t8y8
left a comment
There was a problem hiding this comment.
Needs a simple fix and then looks good to me
Collaborator
|
@shrmnk Hey! Are you still interested in updating the patch and merging this? |
Contributor
Author
|
Hey sorry missed out on this. Fixed! |
Collaborator
|
@shrmnk Looks good! But, as I was about to merge, I noticed this is against master, can you rebase it against |
Contributor
Author
|
Rebased to |
Collaborator
|
It looks like it's still showing as a PR trying to merge in to 'master' |
Contributor
|
@t8y8 check I didn't break anything? |
Collaborator
|
WE CAN CHANGE THE TARGET BRANCH?!?! I never knew! |
shinchris
pushed a commit
that referenced
this pull request
Feb 21, 2020
* Added a way to handle non-xml errors (#515) * Added Webhooks endpoints for create, delete, get, list, and test (#523, #532) * Added delete method in the tasks endpoint (#524) * Added description attribute to WorkbookItem (#533) * Added support for materializeViews as schedule and task types (#542) * Added warnings to schedules (#550, #551) * Added ability to update parent_id attribute of projects (#560, #567) * Improved filename behavior for download endpoints (#517) * Improved logging (#508) * Fixed runtime error in permissions endpoint (#513) * Fixed move_workbook_sites sample (#503) * Fixed project permissions endpoints (#527) * Fixed login.py sample to accept site name (#549)
shinchris
pushed a commit
that referenced
this pull request
Feb 21, 2020
Merging v0.10 changes from development to master * Added a way to handle non-xml errors (#515) * Added Webhooks endpoints for create, delete, get, list, and test (#523, #532) * Added delete method in the tasks endpoint (#524) * Added description attribute to WorkbookItem (#533) * Added support for materializeViews as schedule and task types (#542) * Added warnings to schedules (#550, #551) * Added ability to update parent_id attribute of projects (#560, #567) * Improved filename behavior for download endpoints (#517) * Improved logging (#508) * Fixed runtime error in permissions endpoint (#513) * Fixed move_workbook_sites sample (#503) * Fixed project permissions endpoints (#527) * Fixed login.py sample to accept site name (#549)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fixes in logging texts for the workbooks_endpoint.py file