Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Thank you #3

Copy link
Copy link

Description

@joonas-fi
Issue body actions

I just want to say, that I've seen and produced a truckload of Go code, and the overall code quality of this library is very, very good!

A few highlights:

  • The code is self-documenting,
  • The package structure is sensible, e.g. boot sector stuff in own package
  • I would've had to build a "fragment reader" myself, but you had it ready. It was a joy. :)
  • Where you saw fit to add comments, they were truly for need like this line
    // fragment.Reader). Note that data will probably not align to a cluster exactly so there could be some padding at the
    (when I saw that I immediately realized what the bug in my software was)

Good job! You rock.

Sorry to spam issue tracker, I couldn't find other contact details :)

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.