[DX] ADR usage #8153
Update adr.rst
Updated the syntax errors and unused use statements.
- Loading branch information
commit 97bcbacbcc2bf89c6e304952c1a201563213c8ae
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,14 +4,15 @@ single: Action Domain Responder approach | |
| How to implement the ADR pattern | ||
| ================================ | ||
|
|
||
| In Symfony, you're used to implement the MVC pattern and extending the default :class:`Symfony\\Bundle\\FrameworkBundle\\Controller\\Controller` | ||
| class. | ||
| Since the 3.3 update, Symfony is capable of using natively the ADR approach. | ||
|
There was a problem hiding this comment. Maybe it is worth it to add a link to https://github.com/pmjones/adr |
||
|
|
||
| Updating your configuration | ||
| --------------------------- | ||
|
|
||
| As the framework evolve, you must update the services.yml file in order to | ||
|
|
||
| use the latest features of the DependencyInjection component, this way, here's the updates:: | ||
|
|
||
| # ... | ||
|
|
||
|
|
||
|
|
@@ -26,14 +27,13 @@ use the latest features of the DependencyInjection component, this way, here's t | |
| resource: '../../src/AppBundle/Action/' | ||
| public: true | ||
|
There was a problem hiding this comment. This behavior has been modified for 3.3, now all the services tagged with |
||
|
|
||
| Once the file is updated, delete your Controller folder and create an Action class using the ADR principles, i.e:: | ||
|
|
||
| <?php | ||
|
|
||
| namespace AppBundle\Action; | ||
|
|
||
| use Twig\Environment; | ||
|
|
||
| final class HelloAction | ||
| { | ||
|
|
@@ -53,10 +53,10 @@ Once the file is updated, delete your Controller folder and create an Action cla | |
| .. tip:: | ||
|
|
||
| As described in the DependencyInjection doc, you must use the __construct() injection | ||
| approach, this way, your class is easier to update and keep in sync with any framework internal | ||
| services. | ||
|
|
||
| By default, we define the class with the final keyword because this class shouldn't be extended, | ||
| the logic is pretty simple to understand as you understand the ADR pattern, in fact, the 'Action' | ||
| is linked to a single request and his dependencies are linked to this precise Action. | ||
|
|
||
|
|
@@ -66,7 +66,7 @@ is linked to a single request and his dependencies are linked to this precise Ac | |
| is faster to return and easier to keep out of the framework logic. | ||
|
|
||
|
|
||
|
|
||
| Once this is done, you can define the routes like before using multiples approach: | ||
|
There was a problem hiding this comment. "multiples approach" => "multiple approaches" |
||
|
|
||
| .. configuration-block:: | ||
|
|
||
|
|
@@ -158,7 +158,7 @@ using this approach, a simple update is recommended :: | |
| } | ||
| } | ||
|
|
||
| This way, you can easily access to parameters:: | ||
|
|
||
| <?php | ||
|
|
||
|
|
@@ -174,7 +174,7 @@ This way, you can easily access to parameters :: | |
| { | ||
| $data = $this->requestStack->getCurrentRequest()->get('id'); | ||
|
There was a problem hiding this comment.
|
||
|
|
||
| return new Response($this->twig->render('default/index.html.twig', ['data' => $data])); | ||
|
There was a problem hiding this comment. We still use the long syntax in the core and in the docs to ease merging olders branches. |
||
| } | ||
| } | ||
|
|
||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Symfony has never promoted the MVC pattern (at least, not since version 2). Instead, we are presenting Symfony as being a Request/Response framework where the controller converts a Request to a Response via a Controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, my apologies for this words, the meaning of my "text" was to clearly say that a lot of developers use Symfony with MVC and that using this pattern is way more used than just transforming a Request into Response (which is handled by the framework in a certain way, the actual transformation occurs in the controller).