[DX] ADR usage #8153
Corrected the index typo.
- Loading branch information
commit 0d2022ad3cc9ce5a75ef1265fb0ddb5ff3ebda9c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| .. index:: | ||
| single: Action Domain Responder approach | ||
|
|
||
| How to implement the ADR pattern | ||
| ================================ | ||
|
|
||
| In Symfony, you're used to implement the MVC pattern and extending the default :class:`Symfony\\Bundle\\FrameworkBundle\\Controller\\Controller` | ||
| class. | ||
| Since the 3.3 update, Symfony is capable of using natively the ADR approach. | ||
|
There was a problem hiding this comment. Maybe it is worth it to add a link to https://github.com/pmjones/adr |
||
|
|
||
| Updating your configuration | ||
|
|
@@ -109,7 +109,7 @@ Once this is done, you can define the routes like before using multiples approac | |
|
|
||
| // app/config/routing.php | ||
| use AppBundle\Action\HelloAction | ||
|
|
||
| $collection->add('hello', new Route('/hello', array( | ||
| '_controller' => HelloAction::class, | ||
| ))); | ||
|
|
@@ -156,7 +156,7 @@ Like you can easily imagine, the :class:`Symfony\\Component\Httpfoundation\Reque | |
| public function __invoke() : Response | ||
| { | ||
| $data = $this->requestStack->getCurrentRequest()->get('id'); | ||
|
There was a problem hiding this comment.
|
||
|
|
||
| return new Response($this->twig->render('default/index.html.twig', array('data' => $data)); | ||
|
There was a problem hiding this comment. i think PHP7 is assumed in the doc There was a problem hiding this comment. Do you think we should use the [] syntax? |
||
| } | ||
| } | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Symfony has never promoted the MVC pattern (at least, not since version 2). Instead, we are presenting Symfony as being a Request/Response framework where the controller converts a Request to a Response via a Controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, my apologies for this words, the meaning of my "text" was to clearly say that a lot of developers use Symfony with MVC and that using this pattern is way more used than just transforming a Request into Response (which is handled by the framework in a certain way, the actual transformation occurs in the controller).