Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[2.0] Add paragraph about ask a validated response in the console component #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2012

Conversation

romainneutron
Copy link
Contributor

Hello,

this PR moves a part of #1822 in 2.0

Romain

$dialog = $this->getHelperSet()->get('dialog');

$validator = function ($value) {
if (trim($value) == '') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the expected == current method in Symfony2:

if ('' == trim($value)) {

@romainneutron
Copy link
Contributor Author

PR updated, I added some words about the callback.

weaverryan added a commit that referenced this pull request Nov 10, 2012
[2.0] Add paragraph about ask a validated response in the console component
@weaverryan weaverryan merged commit 4a11852 into symfony:2.0 Nov 10, 2012
@weaverryan
Copy link
Member

Looks great - thanks Romain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.