Add documentation about hidden response method in Console helper #1822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fifth argument is the default value. | ||
|
|
||
| .. versionadded:: 2.2 | ||
| The ``askHiddenResponse`` method was added in Symfony 2.2. |
|
Hey Romain! One thing we do need to do right now is make a separate PR against 2.0 with all the things except for the 2.2 new features. Are you able to do that? I can do some patching on your behalf, but I try not to make commits "on behalf" of others (but I do want you to get credit for the updates!) Let me know - thanks! |
|
I'm gonna do this RIGHT NOW :) |
|
Is this ok @weaverryan ? Let me know whan it's merged as I will rebase this one |
|
@romainneutron Merged! Rebase rebase rebase :) |
|
@weaverryan you don't want to merge 2.0 in master before I rebase ? |
|
Hey Romain! I'm all merged in right now - you should be ready to go now :) Thanks! |
|
it's all done @weaverryan ! |
weaverryan
added a commit
that referenced
this pull request
Nov 16, 2012
Add documentation about hidden response method in Console helper
weaverryan
added a commit
that referenced
this pull request
Nov 16, 2012
|
Merged - thanks so much! |
|
thank to you Ryan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds docs to symfony/symfony#5731