Use valid version in maintainer guide #13175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Feb 18, 2020
HeahDude
reviewed
Feb 18, 2020
| @@ -195,7 +195,7 @@ Step 3: Merge it into the other branches | ||
|
|
||
| If a PR has not been merged in ``master``, you must merge it up into all the | ||
| maintained branches until ``master``. Imagine that you are merging a PR against | ||
| ``3.4`` and the maintained branches are ``3.4``, ``4.2`` and ``master``: | ||
| ``3.4`` and the maintained branches are ``3.4``, ``4.4`` and ``master``: |
There was a problem hiding this comment.
I do this while upmerging 👍🏻
OskarStark
added a commit
that referenced
this pull request
Feb 19, 2020
This PR was merged into the 3.4 branch. Discussion ---------- Use valid version in maintainer guide <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 2a596de Use valid version in maintainer guide
OskarStark
added a commit
that referenced
this pull request
Feb 19, 2020
OskarStark
added a commit
that referenced
this pull request
Feb 19, 2020
* 4.4: Update http_authentication.rst Update routing.rst Update routing.rst Update mailer.rst Update messenger.rst Reference method Update form.rst Use valid versionj in maintainer guide. refs #13175 [DependencyInjection] Fixed public service use case fixup tweak #13099 Use valid version in maintainer guide Mention region parameter for Mailgun mailer too Update service_subscribers_locators.rst
OskarStark
added a commit
that referenced
this pull request
Feb 19, 2020
* 5.0: Update http_authentication.rst Update routing.rst Update routing.rst Update mailer.rst Update messenger.rst Reference method Update form.rst Use valid versionj in maintainer guide. refs #13175 [DependencyInjection] Fixed public service use case Use valid version in maintainer guide Mention region parameter for Mailgun mailer too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.