Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update service_subscribers_locators.rst #13099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Update service_subscribers_locators.rst #13099

merged 1 commit into from
Feb 19, 2020

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented Feb 10, 2020

According to symfony/symfony#34637, index_by attribute must be set to make default_index_method working

According to symfony/symfony#34637, `index_by` attribute must be set to make `default_index_method` working
@HeahDude
Copy link
Contributor

Good catch, thanks @l-vo.

HeahDude added a commit that referenced this pull request Feb 19, 2020
This PR was merged into the 4.4 branch.

Discussion
----------

Update service_subscribers_locators.rst

According to symfony/symfony#34637, `index_by` attribute must be set to make `default_index_method` working

Commits
-------

e382dff Update service_subscribers_locators.rst
@HeahDude HeahDude merged commit e382dff into symfony:4.4 Feb 19, 2020
HeahDude added a commit that referenced this pull request Feb 19, 2020
HeahDude added a commit that referenced this pull request Feb 19, 2020
* 4.4:
  fixup
  tweak #13099
  Update service_subscribers_locators.rst
OskarStark added a commit that referenced this pull request Feb 19, 2020
* 4.4:
  Update http_authentication.rst
  Update routing.rst
  Update routing.rst
  Update mailer.rst
  Update messenger.rst
  Reference method
  Update form.rst
  Use valid versionj in maintainer guide. refs #13175
  [DependencyInjection] Fixed public service use case
  fixup
  tweak #13099
  Use valid version in maintainer guide
  Mention region parameter for Mailgun mailer too
  Update service_subscribers_locators.rst
@walva
Copy link
Contributor

walva commented May 10, 2020

Hi there!
When you look on google for this feature "symfony tagged service" you end up pages such as:

None of them were pointing to Service Subscribers & Locators > Indexing the Collection of Services.
I took me 1h+ to find my problem (addressed in this issue). It may be worth it to rework the linking between pages? The news is well referenced and contains the same mistake as the doc used to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.