-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
#27345 Added Symfony\Component\Lock\Store\MongoDbStore #11735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#27345 Added Symfony\Component\Lock\Store\MongoDbStore #11735
Conversation
afab849
to
02493d3
Compare
|
5f7b165
to
13bddeb
Compare
This PR was submitted for the 4.4 branch but it was squashed and merged into the 5.1-dev branch instead (closes #31889). Discussion ---------- [Lock] add mongodb store | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes (requires `ext-mongodb` and `mongodb/mongodb` to test) | Fixed tickets | #27345 | License | MIT | Original Doc PR | symfony/symfony-docs#9807 | Remove from 4.3 Doc PR | symfony/symfony-docs#11686 | Add to 4.4 Doc PR | symfony/symfony-docs#11735 Looks like I messed up `kralos:27345-lock-mongodb` with a force push (trying to fix ci issues) right before it was merged to `master` (`4.3.0`). see #27648 **Description** We should support Semaphore Locks with a MongoDB back end to allow those that already use MongoDB as a distributed storage engine. Symfony already partially supports MongoDB for session storage: `Symfony\Component\HttpFoundation\Session\Storage\Handler\MongoDbSessionHandler` **Example** ```php $client = new MongoDb\Client(); $store = new Symfony\Component\Lock\Store\MongoDbStore( $client array( 'database' => 'my-app', ) ); $lockFactory = new Symfony\Component\Lock\Factory($store); $lock = $lockFactory->createLock('my-resource'); ``` Commits ------- a6bfa59 [Lock] add mongodb store
ab51419
to
e8d6e49
Compare
Since @fabpot just merged symfony/symfony#31889 I've re-based this from |
8087cd4
to
392140a
Compare
392140a
to
679a77e
Compare
The code for this has been merged into |
da1382e
to
cc02ab4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kralos thanks a lot for your contribution. I tried to merge it with the internal tool we use to merge Symfony PRs ... but I faced an error that I couldn't fix myself. So, could you please rebase your PR one last time? Thanks!
cc02ab4
to
934401f
Compare
@javiereguiluz I've fixed the branch, also noticed the DBAL link was broken (Doctrine dropped the DBAL dir using psr-4) so i've updated it |
Merged! Thanks a lot for the extra effort needed to rebase and get this PR ready. |
Added Lock MongoDbStore documentation to symfony 5.1