Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Lock] mongodb store removed from symfony 4.3 #11686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

kralos
Copy link

@kralos kralos commented Jun 6, 2019

MongoDbStore wasn't actually added in symfony 4.3, it will be added in 4.4.

See symfony/symfony#31889

@javiereguiluz
Copy link
Member

@kralos I wasn't aware of this. Thanks for taking care of updating it.

@javiereguiluz javiereguiluz merged commit 75ad033 into symfony:4.3 Jun 12, 2019
javiereguiluz added a commit that referenced this pull request Jun 12, 2019
This PR was merged into the 4.3 branch.

Discussion
----------

[Lock] mongodb store removed from symfony 4.3

MongoDbStore wasn't actually added in symfony 4.3, it will be added in 4.4.

See symfony/symfony#31889

Commits
-------

75ad033 #27345 Removed Lock MongoDbStore, it will be added in symfony 4.4
fabpot added a commit to symfony/symfony that referenced this pull request Dec 11, 2019
This PR was submitted for the 4.4 branch but it was squashed and merged into the 5.1-dev branch instead (closes #31889).

Discussion
----------

[Lock] add mongodb store

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes (requires `ext-mongodb` and `mongodb/mongodb` to test)
| Fixed tickets | #27345
| License       | MIT
| Original Doc PR        | symfony/symfony-docs#9807
| Remove from 4.3 Doc PR | symfony/symfony-docs#11686
| Add to 4.4 Doc PR | symfony/symfony-docs#11735

Looks like I messed up `kralos:27345-lock-mongodb` with a force push (trying to fix ci issues) right before it was merged to `master` (`4.3.0`).

see #27648

**Description**
We should support Semaphore Locks with a MongoDB back end to allow those that already use MongoDB as a distributed storage engine.

Symfony already partially supports MongoDB for session storage: `Symfony\Component\HttpFoundation\Session\Storage\Handler\MongoDbSessionHandler`

**Example**

```php
$client = new MongoDb\Client();

$store = new Symfony\Component\Lock\Store\MongoDbStore(
    $client
    array(
        'database' => 'my-app',
    )
);
$lockFactory = new Symfony\Component\Lock\Factory($store);
$lock = $lockFactory->createLock('my-resource');
```

Commits
-------

a6bfa59 [Lock] add mongodb store
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.