Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update choice_label docs to match given examples #11016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update choice_label docs to match given examples #11016

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af8cf57
Update choice_label docs to match given examples
JarJak Feb 19, 2019
ab88da0
Make choice_label docs even more clear
JarJak Feb 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update choice_label docs to match given examples
  • Loading branch information
@JarJak
JarJak authored Feb 19, 2019
commit af8cf57e7a0ca952e744254e36a98062e2137d46
6 changes: 3 additions & 3 deletions 6 reference/forms/types/options/choice_label.rst.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ more control::
'maybe' => null,
],
'choice_label' => function ($choiceValue, $key, $value) {
if ($value == $choiceValue) {
if (true === $choiceValue) {
return 'Definitely!';
}

Expand All @@ -28,8 +28,8 @@ more control::
},
]);

This method is called for *each* choice, passing you the choice ``$value`` and the
``$key`` from the choices array (``$index`` is related to `choice_value`_). This
This method is called for *each* choice, passing you the ``$choiceValue`` and the
``$key`` from the choices array (``$value`` is related to `choice_value`_). This
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "$value is related to choice_value_" part doesn't look right to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you propose then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this:

This method is called for *each* choice, passing you the ``$choiceValue``
(related to `choice_value`_), the ``$key`` from the choices array and the
``$value``. This will give you:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

will give you:

.. image:: /_images/reference/form/choice-example2.png
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.