Update choice_label docs to match given examples #11016
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Feb 20, 2019
| This method is called for *each* choice, passing you the choice ``$value`` and the | ||
| ``$key`` from the choices array (``$index`` is related to `choice_value`_). This | ||
| This method is called for *each* choice, passing you the ``$choiceValue`` and the | ||
| ``$key`` from the choices array (``$value`` is related to `choice_value`_). This |
There was a problem hiding this comment.
the "$value is related to choice_value_" part doesn't look right to me.
There was a problem hiding this comment.
what do you propose then?
There was a problem hiding this comment.
Maybe something like this:
This method is called for *each* choice, passing you the ``$choiceValue``
(related to `choice_value`_), the ``$key`` from the choices array and the
``$value``. This will give you:
xabbuh
approved these changes
Feb 21, 2019
|
@JarJak thanks for fixing this bug! We merged it in 3.4 branch; that's why GitHub displays it as closed instead of merged, but it's merged. |
javiereguiluz
added a commit
that referenced
this pull request
Feb 21, 2019
This PR was submitted for the 4.2 branch but it was squashed and merged into the 3.4 branch instead (closes #11016). Discussion ---------- Update choice_label docs to match given examples Code, description and image in the example did not match. Commits ------- 67e716b Update choice_label docs to match given examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code, description and image in the example did not match.