[RC][Form] Let null values clear fields in PATCH requests #9146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a test case? |
|
I'm doing a rebase since there are some commits in between |
| $form->setData($author); | ||
| $form->submit(array('lastName' => null), false); | ||
|
|
||
| $this->assertNull($author->getLastName()); |
There was a problem hiding this comment.
Sorry, I seem to have given too little information here. The current test cases for this functionality are located in CompoundFormTest:85++, so we should also add this test case there. For example:
public function testSubmitForwardsNullIfNotClearMissingButValueIsExplicitlyNull()
{
$child = $this->getMockForm('firstName');
$this->form->add($child);
$child->expects($this->once())
->method('submit')
->with($this->equalTo(null));
$this->form->submit(array('firstName' => null), false);
}There was a problem hiding this comment.
Oh sorry for that! Going to add this too.
|
Ok Added that test too and rebased |
|
Awesome, thanks. You can remove the other test. Could you also squash the commits into the first one please? |
|
Rebased and squashed ;) |
|
Are there any guidelines in where to write tests depending on what to test? So next time I write it correctly on first time :) |
|
This might be related to #8412 |
|
@alex88 Thanks! :) The best thing is to check where the modified functionality is currently tested and to add new tests there. If there are multiple tests for some functionality, you should go to the tests for the lowest layer in the architecture (for example, |
|
@bschussek thanks for the tip! I'll watch more carefully next time! |
This was referenced Feb 12, 2014
fabpot
added a commit
that referenced
this pull request
Mar 3, 2014
…ra field. (jenkoian) This PR was squashed before being merged into the 2.3 branch (closes #10251). Discussion ---------- [Form][2.3] Fixes empty file-inputs getting treated as extra field. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8575 (#8575 (comment)) | License | MIT Re-applies 968fe23 (PR #8575). The test for this already exists, it was just this line that got overwritten by eb9f76d#diff-ca5e25b47f3ecc94cd557946aeb486c6L542 To clarify, this is a PR into 2.3 branch - this already exists in 2.4 (and later from this PR: #9146) Commits ------- 8d99d75 [Form][2.3] Fixes empty file-inputs getting treated as extra field.
fabpot
added a commit
to symfony/form
that referenced
this pull request
Mar 3, 2014
…ra field. (jenkoian) This PR was squashed before being merged into the 2.3 branch (closes #10251). Discussion ---------- [Form][2.3] Fixes empty file-inputs getting treated as extra field. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8575 (symfony/symfony#8575 (comment)) | License | MIT Re-applies 968fe23 (PR #8575). The test for this already exists, it was just this line that got overwritten by symfony/symfony@eb9f76d#diff-ca5e25b47f3ecc94cd557946aeb486c6L542 To clarify, this is a PR into 2.3 branch - this already exists in 2.4 (and later from this PR: symfony/symfony#9146) Commits ------- 8d99d75 [Form][2.3] Fixes empty file-inputs getting treated as extra field.
fabpot
added a commit
to symfony/form
that referenced
this pull request
Mar 3, 2014
…ra field. (jenkoian) This PR was squashed before being merged into the 2.3 branch (closes #10251). Discussion ---------- [Form][2.3] Fixes empty file-inputs getting treated as extra field. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8575 (symfony/symfony#8575 (comment)) | License | MIT Re-applies 968fe23 (PR #8575). The test for this already exists, it was just this line that got overwritten by symfony/symfony@eb9f76d#diff-ca5e25b47f3ecc94cd557946aeb486c6L542 To clarify, this is a PR into 2.3 branch - this already exists in 2.4 (and later from this PR: symfony/symfony#9146) Commits ------- 8d99d75 [Form][2.3] Fixes empty file-inputs getting treated as extra field.
fabpot
added a commit
to symfony/form
that referenced
this pull request
May 23, 2014
…ra field. (jenkoian) This PR was squashed before being merged into the 2.3 branch (closes #10251). Discussion ---------- [Form][2.3] Fixes empty file-inputs getting treated as extra field. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8575 (symfony/symfony#8575 (comment)) | License | MIT Re-applies 968fe23 (PR #8575). The test for this already exists, it was just this line that got overwritten by symfony/symfony@eb9f76d#diff-ca5e25b47f3ecc94cd557946aeb486c6L542 To clarify, this is a PR into 2.3 branch - this already exists in 2.4 (and later from this PR: symfony/symfony#9146) Commits ------- 8d99d75 [Form][2.3] Fixes empty file-inputs getting treated as extra field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the way form checks wherever or not to submit childs by checking submitted data with array_key_exists and not with just isset.
This way in PATCH requests values are not processed when they are not in array and not also when the value is null. Currently there is no way to null a value with a PATCH request, even passing it null.
This can lead to some BC breaks depending on how users used form in their code.