[Form] fixes empty file-inputs get treated as extra field #8575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flask
commented
Jul 25, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #8548, #8566 |
| License | MIT |
|
Can you add a test covering this to avoid regressions ? |
… additional fields
|
Test added. I'm not quite sure if this is the proper way to test this use case. Maybe there is a way around getting the factory from the |
|
this bug is really problematic, how can i configure composer to regress sf version ? |
|
@kelu95 |
fabpot
added a commit
that referenced
this pull request
Jul 26, 2013
This PR was squashed before being merged into the 2.3 branch (closes #8575). Discussion ---------- [Form] fixes empty file-inputs get treated as extra field | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8548, #8566 | License | MIT Commits ------- e5fba3c [Form] fixes empty file-inputs get treated as extra field
|
Added a PR for my above comment: #10251 |
fabpot
added a commit
that referenced
this pull request
Mar 3, 2014
…ra field. (jenkoian) This PR was squashed before being merged into the 2.3 branch (closes #10251). Discussion ---------- [Form][2.3] Fixes empty file-inputs getting treated as extra field. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8575 (#8575 (comment)) | License | MIT Re-applies 968fe23 (PR #8575). The test for this already exists, it was just this line that got overwritten by eb9f76d#diff-ca5e25b47f3ecc94cd557946aeb486c6L542 To clarify, this is a PR into 2.3 branch - this already exists in 2.4 (and later from this PR: #9146) Commits ------- 8d99d75 [Form][2.3] Fixes empty file-inputs getting treated as extra field.
fabpot
added a commit
to symfony/form
that referenced
this pull request
Mar 3, 2014
…ra field. (jenkoian) This PR was squashed before being merged into the 2.3 branch (closes #10251). Discussion ---------- [Form][2.3] Fixes empty file-inputs getting treated as extra field. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8575 (symfony/symfony#8575 (comment)) | License | MIT Re-applies 968fe23 (PR #8575). The test for this already exists, it was just this line that got overwritten by symfony/symfony@eb9f76d#diff-ca5e25b47f3ecc94cd557946aeb486c6L542 To clarify, this is a PR into 2.3 branch - this already exists in 2.4 (and later from this PR: symfony/symfony#9146) Commits ------- 8d99d75 [Form][2.3] Fixes empty file-inputs getting treated as extra field.
fabpot
added a commit
to symfony/form
that referenced
this pull request
Mar 3, 2014
…ra field. (jenkoian) This PR was squashed before being merged into the 2.3 branch (closes #10251). Discussion ---------- [Form][2.3] Fixes empty file-inputs getting treated as extra field. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8575 (symfony/symfony#8575 (comment)) | License | MIT Re-applies 968fe23 (PR #8575). The test for this already exists, it was just this line that got overwritten by symfony/symfony@eb9f76d#diff-ca5e25b47f3ecc94cd557946aeb486c6L542 To clarify, this is a PR into 2.3 branch - this already exists in 2.4 (and later from this PR: symfony/symfony#9146) Commits ------- 8d99d75 [Form][2.3] Fixes empty file-inputs getting treated as extra field.
fabpot
added a commit
to symfony/form
that referenced
this pull request
May 23, 2014
…ra field. (jenkoian) This PR was squashed before being merged into the 2.3 branch (closes #10251). Discussion ---------- [Form][2.3] Fixes empty file-inputs getting treated as extra field. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8575 (symfony/symfony#8575 (comment)) | License | MIT Re-applies 968fe23 (PR #8575). The test for this already exists, it was just this line that got overwritten by symfony/symfony@eb9f76d#diff-ca5e25b47f3ecc94cd557946aeb486c6L542 To clarify, this is a PR into 2.3 branch - this already exists in 2.4 (and later from this PR: symfony/symfony#9146) Commits ------- 8d99d75 [Form][2.3] Fixes empty file-inputs getting treated as extra field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.