Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Tui] Throw when ext-zip is not installed and one tries to load a zipped figlet #64356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabpot merged 1 commit into from
May 24, 2026
Merged

[Tui] Throw when ext-zip is not installed and one tries to load a zipped figlet #64356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions 2 src/Symfony/Component/Tui/Tests/Widget/Figlet/FigletFontTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
namespace Symfony\Component\Tui\Tests\Widget\Figlet;

use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\RequiresPhpExtension;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Tui\Exception\InvalidArgumentException;
use Symfony\Component\Tui\Widget\Figlet\FigletFont;
Expand Down Expand Up @@ -95,6 +96,7 @@ public function testLoadNonExistentFile()
FigletFont::load('/nonexistent/path/to/font.flf');
}

#[RequiresPhpExtension('zip')]
public function testLoadZipRejectsOversizedDecompressedEntry()
{
$path = tempnam(sys_get_temp_dir(), 'flf_zip_').'.zip';
Expand Down
4 changes: 4 additions & 0 deletions 4 src/Symfony/Component/Tui/Widget/Figlet/FigletFont.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@ private function readCharacterLines(array $lines, int &$lineIndex): ?array
*/
private static function extractFromZip(string $path): string
{
if (!\extension_loaded('zip')) {
throw new InvalidArgumentException('The ZIP extension is required to load FIGlet fonts from ZIP archives.');
}

$zip = new \ZipArchive();

if (true !== $zip->open($path)) {
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.