[Cache] Fix strlen(null) deprecation on RelayCluster path in RedisTrait::doClear()#64330
Merged
nicolas-grekas merged 1 commit intoMay 23, 2026
symfony:7.4symfony/symfony:7.4from
signor-pedro:fix-cache-redistrait-null-prefix-strlen-deprecationsignor-pedro/symfony:fix-cache-redistrait-null-prefix-strlen-deprecationCopy head branch name to clipboard
Merged
[Cache] Fix strlen(null) deprecation on RelayCluster path in RedisTrait::doClear()#64330nicolas-grekas merged 1 commit intosymfony:7.4symfony/symfony:7.4from signor-pedro:fix-cache-redistrait-null-prefix-strlen-deprecationsignor-pedro/symfony:fix-cache-redistrait-null-prefix-strlen-deprecationCopy head branch name to clipboard
nicolas-grekas merged 1 commit into
symfony:7.4symfony/symfony:7.4from
signor-pedro:fix-cache-redistrait-null-prefix-strlen-deprecationsignor-pedro/symfony:fix-cache-redistrait-null-prefix-strlen-deprecationCopy head branch name to clipboard
Conversation
Contributor
Author
|
There are many CI failures but frankly, I don't see how these could relate to my change. I at least fixed some formatting as suggested by fabbot, but the only meaningful change is $prefixLen = \strlen($prefix ?? '');Am I supposed to fix the rest of the failing jobs? |
8ae5ccc to
68021d6
Compare
Member
|
Thank you @signor-pedro. |
This was referenced May 27, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
?? ''null guard already used on every other branch ofRedisTrait::doClear().Relay::OPT_PREFIXcan benull, which triggers a PHP 8.1+strlen(): Passing null...deprecation.