[Yaml] Allow trailing newlines after the end-of-document marker#64316
Merged
Merged
[Yaml] Allow trailing newlines after the end-of-document marker#64316
Conversation
The hardened `#\.\.\.[ \t]*+$#` regex introduced in 9749cd4 only accepts horizontal whitespace after `...`, so a YAML document ending with the marker followed by a blank line is no longer stripped and the parser errors on the leftover `...`. Restore the previous tolerance for any trailing whitespace by using `\s*+$`; the possessive quantifier keeps the pattern safe from catastrophic backtracking.
|
Hey! Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
GromNaN
approved these changes
May 20, 2026
derrabus
approved these changes
May 21, 2026
This was referenced May 27, 2026
Merged
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hardened
#\.\.\.[ \t]*+$#regex introduced in 9749cd4 only accepts horizontal whitespace after the...end-of-document marker, so a document ending with a blank line after...is no longer stripped and the parser errors on the leftover marker. Restore the previous tolerance using\s*+$; the possessive quantifier keeps the pattern safe from catastrophic backtracking since nothing follows it.