[HttpKernel][WebProfilerBundle] Check logs priority name for both WARNING and warning#64310
Merged
nicolas-grekas merged 1 commit intoMay 20, 2026
symfony:6.4symfony/symfony:6.4from
MatTheCat:profiler_warning_countMatTheCat/symfony:profiler_warning_countCopy head branch name to clipboard
Merged
[HttpKernel][WebProfilerBundle] Check logs priority name for both WARNING and warning#64310nicolas-grekas merged 1 commit intosymfony:6.4symfony/symfony:6.4from MatTheCat:profiler_warning_countMatTheCat/symfony:profiler_warning_countCopy head branch name to clipboard
WARNING and warning#64310nicolas-grekas merged 1 commit into
symfony:6.4symfony/symfony:6.4from
MatTheCat:profiler_warning_countMatTheCat/symfony:profiler_warning_countCopy head branch name to clipboard
Conversation
GromNaN
reviewed
May 20, 2026
Member
GromNaN
left a comment
There was a problem hiding this comment.
Is it possible to add a regression test?
bb332ba to
5025620
Compare
Contributor
Author
|
@GromNaN thanks for the review I have addressed your feedback. |
GromNaN
approved these changes
May 20, 2026
5025620 to
75f2743
Compare
WARNING and warning
…RNING` and `warning`
Contributor
Author
|
Updated the comparisons in the profiler template as well. |
Member
|
Thank you @MatTheCat. |
This was referenced May 27, 2026
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LoggerDataCollectormatches logs’priorityNameagainstWARNINGto count them, but this value comes fromMonolog\Level::getName(), meaning it is uppercase.Meanwhile, the HttpKernel logger uses
Psr\Log\LogLevelconstants which are lowercased. That means the warning count is always zero when using it.This PR checks against both cases to fix this.