[Translation] Don’t check the error message to know if Lokalise keys are missing#64289
Merged
nicolas-grekas merged 1 commit intoMay 20, 2026
symfony:6.4symfony/symfony:6.4from
MatTheCat:lokalise_export_filesMatTheCat/symfony:lokalise_export_filesCopy head branch name to clipboard
Merged
[Translation] Don’t check the error message to know if Lokalise keys are missing#64289nicolas-grekas merged 1 commit intosymfony:6.4symfony/symfony:6.4from MatTheCat:lokalise_export_filesMatTheCat/symfony:lokalise_export_filesCopy head branch name to clipboard
nicolas-grekas merged 1 commit into
symfony:6.4symfony/symfony:6.4from
MatTheCat:lokalise_export_filesMatTheCat/symfony:lokalise_export_filesCopy head branch name to clipboard
Conversation
MatTheCat
commented
May 19, 2026
| } | ||
|
|
||
| if (200 !== $response->getStatusCode()) { | ||
| if (self::PROJECT_TOO_BIG_STATUS_CODE !== ($responseContent['error']['code'] ?? null)) { |
Contributor
Author
There was a problem hiding this comment.
This code is the same as the response’s so we don’t need to wait for the content.
MatTheCat
commented
May 19, 2026
Comment on lines
-147
to
-149
| /** | ||
| * @see https://app.lokalise.com/api2docs/curl/#transition-download-files-post | ||
| */ |
Contributor
Author
There was a problem hiding this comment.
Couldn’t find a single reference to this endpoint even using Wayback Machine 🤔
3aa9f51 to
e4d2918
Compare
e4d2918 to
c43252b
Compare
Contributor
Author
|
Sorry for the noise; rebased on the wrong branch. |
c43252b to
b6fe6a0
Compare
Member
|
Thank you @MatTheCat. |
This was referenced May 27, 2026
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushing translations to an empty Lokalise project failed with
because the provider checks for the following message:
Since error responses aren’t documented anywhere and the message can change it probably is better not to take it into account.