[DoctrineBridge] Various fixes and hardenings#64255
Merged
nicolas-grekas merged 1 commit intoMay 18, 2026
symfony:8.1symfony/symfony:8.1from
nicolas-grekas:81-fixes-doctrine-bridgenicolas-grekas/symfony:81-fixes-doctrine-bridgeCopy head branch name to clipboard
Merged
[DoctrineBridge] Various fixes and hardenings#64255nicolas-grekas merged 1 commit intosymfony:8.1symfony/symfony:8.1from nicolas-grekas:81-fixes-doctrine-bridgenicolas-grekas/symfony:81-fixes-doctrine-bridgeCopy head branch name to clipboard
nicolas-grekas merged 1 commit into
symfony:8.1symfony/symfony:8.1from
nicolas-grekas:81-fixes-doctrine-bridgenicolas-grekas/symfony:81-fixes-doctrine-bridgeCopy head branch name to clipboard
Conversation
Member
Do you have a use case in mind for this? I couldn't think of one at the time, and still struggle to. |
Member
Author
|
|
chalasr
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit bundles several small fixes and hardenings in the Doctrine bridge:
EntityValueResolver: add support for#[Option]parameters (previously only#[Argument]was resolved). Expression-language variables now also expose$input->getOptions().EntityValueResolverTrait: remove dead metadata-filter branch inbuildCriteriaFromMapping— the guardnull === $options->mappingwas unreachable from both call sites.MapEntity: document the kebab-case transformation applied to argument/option names by the Console resolver (e.g.userId→user-id).RegisterMappingsPass: fix typo in deprecation message ("alias are" → "aliases are").DoctrineType(Form): drop unreachabledefaultbranch in theuid_formatmatch — already validated bysetAllowedValues.DoctrinePingConnectionMiddleware: in multi-EM mode (no explicitentityManagerName), ping every manager so healthy ones still get reset even if a secondary connection fails. The first failure is rethrown at the end so the worker still retries the message.