[Console] Various fixes and hardenings#64246
Merged
nicolas-grekas merged 1 commit intoMay 18, 2026
symfony:8.1symfony/symfony:8.1from
nicolas-grekas:81-fixes-consolenicolas-grekas/symfony:81-fixes-consoleCopy head branch name to clipboard
Merged
[Console] Various fixes and hardenings#64246nicolas-grekas merged 1 commit intosymfony:8.1symfony/symfony:8.1from nicolas-grekas:81-fixes-consolenicolas-grekas/symfony:81-fixes-consoleCopy head branch name to clipboard
nicolas-grekas merged 1 commit into
symfony:8.1symfony/symfony:8.1from
nicolas-grekas:81-fixes-consolenicolas-grekas/symfony:81-fixes-consoleCopy head branch name to clipboard
Conversation
Member
nicolas-grekas
commented
May 18, 2026
| Q | A |
|---|---|
| Branch? | 8.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | - |
| License | MIT |
GromNaN
reviewed
May 18, 2026
Comment on lines
-166
to
-167
| // Check for: < (tags), \033 (ANSI escape), ]8;; (terminal hyperlink) | ||
| if (!str_contains($string, '<') && !str_contains($string, "\033") && !str_contains($string, ']8;;')) { |
Member
There was a problem hiding this comment.
Why the check on ]8;; is removed?
Member
Author
There was a problem hiding this comment.
because !str_contains(\033) already does the job, hyperlinks do contain one
2ff58de to
3ac093a
Compare
GromNaN
approved these changes
May 18, 2026
3ac093a to
ce7d676
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.