[HttpClient] Various fixes and hardenings#64243
Merged
nicolas-grekas merged 1 commit intoMay 19, 2026
symfony:8.1symfony/symfony:8.1from
nicolas-grekas:81-fixes-http-clientnicolas-grekas/symfony:81-fixes-http-clientCopy head branch name to clipboard
Merged
[HttpClient] Various fixes and hardenings#64243nicolas-grekas merged 1 commit intosymfony:8.1symfony/symfony:8.1from nicolas-grekas:81-fixes-http-clientnicolas-grekas/symfony:81-fixes-http-clientCopy head branch name to clipboard
nicolas-grekas merged 1 commit into
symfony:8.1symfony/symfony:8.1from
nicolas-grekas:81-fixes-http-clientnicolas-grekas/symfony:81-fixes-http-clientCopy head branch name to clipboard
Conversation
Member
nicolas-grekas
commented
May 18, 2026
| Q | A |
|---|---|
| Branch? | 8.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | - |
| License | MIT |
nicolas-grekas
commented
May 18, 2026
| $cachedData['expires_at'] = self::calculateExpiresAt($maxAge); | ||
| $cachedData['stored_at'] = time(); | ||
| $cachedData['initial_age'] = self::getCurrentAge($headers); | ||
| $cachedData['headers'] = $headers; |
Member
Author
There was a problem hiding this comment.
@Lctrs OK for you? Likely something to backport on 7.4 (we need the updated $cachedData in the call to replaceResponse below
Contributor
There was a problem hiding this comment.
If that's okay to group them, I have a few more fixes locally for CachingHttpClient
Member
Author
There was a problem hiding this comment.
sure, can you send them for branch 7.4 where they apply I suppose?
Contributor
There was a problem hiding this comment.
Will do tonight. They conflict with each other so I'll close the 3 PRs I opened and just put it all in a single PR.
4513322 to
0080274
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.