[Tui] Fix unattached widget element styles#64234
Merged
nicolas-grekas merged 1 commit intoMay 20, 2026
symfony:8.1symfony/symfony:8.1from
masskrdjn:fix-markdown-rendermasskrdjn/symfony:fix-markdown-renderCopy head branch name to clipboard
Merged
[Tui] Fix unattached widget element styles#64234nicolas-grekas merged 1 commit intosymfony:8.1symfony/symfony:8.1from masskrdjn:fix-markdown-rendermasskrdjn/symfony:fix-markdown-renderCopy head branch name to clipboard
nicolas-grekas merged 1 commit into
symfony:8.1symfony/symfony:8.1from
masskrdjn:fix-markdown-rendermasskrdjn/symfony:fix-markdown-renderCopy head branch name to clipboard
Conversation
Member
|
Thank you @masskrdjn. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MarkdownWidget::render()can be used directly with a standaloneRenderContext, but sub-element styles were only resolved when the widget was attached to a TUI tree. In that standalone case,AbstractWidget::resolveElement()returned an empty style, so Markdown headings, bold text, italic text, links, and other styled inline elements silently rendered without their default styling.This changes the fallback at the widget level: when a widget is not attached to a context, sub-element styles are resolved from the default TUI stylesheet. That keeps standalone rendering consistent with attached rendering for core widgets.
For example:
Before, the heading kept the raw Markdown marker and inline formatting lost its ANSI styling:
After, the heading content is rendered without the Markdown syntax marker and default ANSI styles are applied to the heading, bold, and italic spans.
A regression test covers rendering an unattached
MarkdownWidgetdirectly withRenderContext.