[Runtime] Fix TypeError when resolving untyped arguments#64215
Merged
Merged
[Runtime] Fix TypeError when resolving untyped arguments#64215
Conversation
Kingdutch
approved these changes
May 15, 2026
Contributor
Kingdutch
left a comment
There was a problem hiding this comment.
Change makes sense to me. If there's no type then there's nothing for resolveType to do. If developers want to special-case the NULL scenario then they have the broader getArgument which they can override.
I think the different behavior for getRuntime makes sense since there's the configurability and mixed is a targettable value for $this->options['runtimes'].
I don't know if the test failures and PHPStan failures are related to this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SymfonyRuntime::getArgument()accepts?string $typebut forwarded null straight toresolveType(string), raising aTypeError. The parentGenericRuntime::getArgument()had the same hole, forwarding null togetRuntime(string).Skip
resolveType()when$typeis null, and letgetRuntime()see'mixed'so it falls through to the standardInvalidArgumentException(whichgetResolver()already catches for optional params).