Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[HttpKernel] Preserve named-attribute override on Request/Session value resolvers#64214

Merged
nicolas-grekas merged 1 commit into
symfony:6.4symfony/symfony:6.4from
nicolas-grekas:hk-argvrnicolas-grekas/symfony:hk-argvrCopy head branch name to clipboard
May 15, 2026
Merged

[HttpKernel] Preserve named-attribute override on Request/Session value resolvers#64214
nicolas-grekas merged 1 commit into
symfony:6.4symfony/symfony:6.4from
nicolas-grekas:hk-argvrnicolas-grekas/symfony:hk-argvrCopy head branch name to clipboard

Conversation

@nicolas-grekas
Copy link
Copy Markdown
Member

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #64212
License MIT

When argument_resolver.request was bumped to priority 120 (above argument_resolver.request_attribute at 100) to keep type-hinted Request arguments from triggering DoctrineBundle's EntityValueResolver, it silently broke the long-standing $this->forward(B::class, ['request' => $modified]) pattern: the matching attribute no longer wins over the sub-request.

Have RequestValueResolver and SessionValueResolver honor a matching named attribute themselves when its value matches the argument type. Non-matching names and non-matching types still short-circuit early enough to keep EntityValueResolver from running for Request arguments.

@nicolas-grekas nicolas-grekas merged commit 8efd735 into symfony:6.4 May 15, 2026
9 of 13 checks passed
@nicolas-grekas nicolas-grekas deleted the hk-argvr branch May 15, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.