Remove usage of Kernel::VERSION#64102
Remove usage of Kernel::VERSION#64102
Kernel::VERSION#64102Conversation
GromNaN
left a comment
There was a problem hiding this comment.
InstalledVersions::getPrettyVersion() may return null if the package is not installed.
The returned version is prefixed by v: v6.4.37 (because the tags have this prefix).
Kernel::VERSION
|
Symfony UX won't be impacted. What about AI cc @OskarStark @chr-hertel? |
|
AFAICS we don't rely on this const either |
|
Should we do this change on 8.1 instead? We cannot safely remove the constant on the LTS branch anyway. |
This PR does not remove the constant. It removes usages of this constant, so that we can safely deprecate the constant in 8.1. |
I am aware.
Yes, but the PR changes components that cannot be installed together with http-kernel 8.1, e.g. framework-bundle 6.4. Touching the old LTS feels pointless. |
|
Not urgent anymore as I've tweaked the release process to always tag 
|
3fc93a5 to
5ed5fae
Compare
5ed5fae to
62cd2cf
Compare
|
Thank you @fabpot. |
I'd like to deprecate
Kernel::VERSIONbut keep all other version related constants inKernel.The problem with
Kernel::VERSIONis that it changes for every patch release, which means thatsymfony/http-kernelis always released even when the component itself has no significant changes.Using Composer directly seems like the better way here.