Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Console] remove conflict rule #60360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

[Console] remove conflict rule #60360

merged 1 commit into from
May 7, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 6, 2025

Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@xabbuh xabbuh requested a review from chalasr as a code owner May 6, 2025 12:26
@carsonbot carsonbot added this to the 7.3 milestone May 6, 2025
@GromNaN
Copy link
Member

GromNaN commented May 6, 2025

Why was there this constraint and why are you removing it?

@xabbuh
Copy link
Member Author

xabbuh commented May 6, 2025

@yceruto added it in #60076 but it turned out that the conflict rule doesn’t seem to be necessary for the test suite to pass.

@yceruto
Copy link
Member

yceruto commented May 6, 2025

I can’t recall the exact reason I introduced this conflict, but based on the nature of that PR, I assume it was related to a deprecation failure. I might be overlooking something, but since @xabbuh confirmed that the failure no longer occurs, I’m fine with removing it.

@fabpot
Copy link
Member

fabpot commented May 7, 2025

Thank you @xabbuh.

@fabpot fabpot merged commit 925dacb into symfony:7.3 May 7, 2025
8 of 11 checks passed
@xabbuh xabbuh deleted the pr-60076 branch May 7, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.