[Console] Deprecate returning a non-int value from a \Closure function set via Command::setCode()
#60076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\Closure function set via Command::setCode()\Closure function set via Command::setCode()
cedfb80 to
afc81af
Compare
\Closure function set via Command::setCode()\Closure function set via Command::setCode()
\Closure function set via Command::setCode()\Closure function set via Command::setCode()
afc81af to
e0ab58a
Compare
…t via `Command::setCode()`
e0ab58a to
787d60a
Compare
fabpot
approved these changes
Mar 29, 2025
nicolas-grekas
approved these changes
Mar 29, 2025
|
Thank you @yceruto. |
Merged
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
May 7, 2025
Since symfony#60076 using a closure as the command code that does not return an integer is deprecated. This means that our tests can trigger deprecations on older branches when the high deps job is run. This usually is not an issue as we silence them with the `SYMFONY_DEPRECATIONS_HELPER` env var. However, phpt tests are run in a child process where the deprecation error handler of the PHPUnit bridge doesn't step in. Thus, for them deprecations are not silenced leading to failures.
Merged
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
May 7, 2025
Since symfony#60076 using a closure as the command code that does not return an integer is deprecated. This means that our tests can trigger deprecations on older branches when the high deps job is run. This usually is not an issue as we silence them with the `SYMFONY_DEPRECATIONS_HELPER` env var. However, phpt tests are run in a child process where the deprecation error handler of the PHPUnit bridge doesn't step in. Thus, for them deprecations are not silenced leading to failures.
fabpot
added a commit
that referenced
this pull request
May 8, 2025
This PR was merged into the 6.4 branch. Discussion ---------- [Runtime] fix tests | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Since #60076 using a closure as the command code that does not return an integer is deprecated. This means that our tests can trigger deprecations on older branches when the high deps job is run. This usually is not an issue as we silence them with the `SYMFONY_DEPRECATIONS_HELPER` env var. However, phpt tests are run in a child process where the deprecation error handler of the PHPUnit bridge doesn't step in. Thus, for them deprecations are not silenced leading to failures. Commits ------- 0b3d980 fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a missing log entry about a deprecation introduced here, and also deprecates returning a
nullvalue for\Closurecode (which was allowed before) and throwing a\TypeErrorfor the new invokable command, making this consistent with theCommand::execute(): intmethod.