Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Security] [LoginLink] Throw InvalidLoginLinkException on invalid parameters #60350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

davidszkiba
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #60347
License MIT

With this change, in addition to checking the presence of the required request parameters, also the type is checked.

@davidszkiba davidszkiba requested a review from chalasr as a code owner May 5, 2025 13:54
@carsonbot carsonbot added this to the 6.4 milestone May 5, 2025
@carsonbot carsonbot changed the title [Security][LoginLink] Throw InvalidLoginLinkException on invalid parameters [Security] [LoginLink] Throw InvalidLoginLinkException on invalid parameters May 5, 2025
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStark OskarStark changed the title [Security] [LoginLink] Throw InvalidLoginLinkException on invalid parameters [Security][LoginLink] Throw InvalidLoginLinkException on invalid parameters May 5, 2025
@OskarStark
Copy link
Contributor

This should be merged into 7.3 IMHO

@chalasr
Copy link
Member

chalasr commented May 5, 2025

As the current behavior results in uncaught errors, this qualifies as a bugfix to me. As #48292

@carsonbot carsonbot changed the title [Security][LoginLink] Throw InvalidLoginLinkException on invalid parameters [Security] [LoginLink] Throw InvalidLoginLinkException on invalid parameters May 7, 2025
@fabpot
Copy link
Member

fabpot commented May 7, 2025

Thank you @davidszkiba.

@fabpot fabpot merged commit 0d971eb into symfony:6.4 May 7, 2025
11 checks passed
@fabpot fabpot mentioned this pull request May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.