[Security] [LoginLink] Throw InvalidLoginLinkException on missing parameter #48292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MatTheCat
commented
Nov 23, 2022
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #48291 |
| License | MIT |
| Doc PR | N/A |
alamirault
approved these changes
Nov 23, 2022
9f3b172 to
dcc314e
Compare
fabpot
requested changes
Nov 26, 2022
src/Symfony/Component/Security/Http/LoginLink/LoginLinkHandler.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/LoginLink/LoginLinkHandler.php
Outdated
Show resolved
Hide resolved
dcc314e to
46f93d3
Compare
chalasr
requested changes
Nov 27, 2022
| throw new InvalidLoginLinkException('Missing "hash" parameter.'); | ||
| } | ||
| if (!$expires = $request->get('expires')) { | ||
| throw new InvalidLoginLinkException('Missing "expires" parameter.'); |
There was a problem hiding this comment.
Other authenticators throw a BadRequestHttpException in such cases, I would do the same here. See e.g.
There was a problem hiding this comment.
Hmm LoginLinkHandlerInterface::consumeLoginLink is supposed to throw InvalidLoginLinkException:
The LoginLinkAuthenticator then converts it to InvalidLoginLinkAuthenticationException which triggers its onAuthenticationFailure method to be called.
Are you sure we should bypass this behavior?
There was a problem hiding this comment.
Thinking twice about it, I think it's safer to go with your approach.
chalasr
approved these changes
Nov 29, 2022
|
Thank you @MatTheCat. |
This was referenced Dec 28, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.