-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Lock] DynamoDB store #60138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
natepage
wants to merge
37
commits into
symfony:7.4
Choose a base branch
from
natepage:feature/lock-dynamodb-store
base: 7.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Lock] DynamoDB store #60138
Changes from 30 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
11c3b24
[Lock][WIP] Initial pass on DynamoDb lock store
natepage c606c47
[Lock][WIP] Move DynamoDbStore into its own bridge package
natepage 93677c8
[Lock][WIP] Test DynamoDbStore against local DynamoDB instance in int…
natepage 03acce4
[Lock][WIP] Address some of reviews comments and CS
natepage 0fec459
[Lock][WIP] Fix license headers
natepage 94bccf3
[Lock][WIP] Fix license headers - 1
natepage 4cef875
[Lock][WIP] Psalm InvalidArgument errors are confusing me...
natepage 02b7368
[Lock][WIP] Try to debug package tests failure
natepage f34fe01
[Lock][WIP] Try to debug package tests failure - 1
natepage fa6c74d
[Lock][WIP] Fix match case for component_bridge in get-modified-packa…
natepage ec36e98
[Lock][WIP] Copy AbstractStoreTestCase from Lock component to bridge
natepage f877628
[Lock][WIP] Disable ssl in integration tests
natepage f3d2a06
[Lock][WIP] Support sslmode option in DynamoDbStore
natepage 31014f9
[Lock][WIP] Fix createTable input
natepage ac28237
[Lock][WIP] Ensure microtime return a float
natepage 10579c6
[Lock][WIP] Fix :token attribute value in putOffExpiration
natepage cd78429
[Lock][WIP] Debug exists function
natepage 0b16e0f
[Lock][WIP] Fix exists logic
natepage a3c7d91
[Lock][WIP] Try to address psalm error
natepage 6484cfa
[Lock][WIP] Make default region and endpoint options null to use defa…
natepage abbc213
[Lock][WIP] Move integration tests to Functional dir and add unit tests
natepage 106eeac
[Lock][WIP] Add unit tests with assertEquals for dsn process
natepage 7dfb08a
[Lock][WIP] Default options in case DynamoDbClient instance given
natepage 170bcef
[Lock][WIP] Replicate constructor testing from SQS Connection
natepage 64e7380
[Lock][WIP] Fix default region in tests
natepage dbb4ae2
[Lock][WIP] Fix invalid and unsupported DSN tests
natepage c685c71
[Lock] Address review comments
natepage 1ff0a60
[Lock] Make fabbot happy
natepage fa64c21
[Lock] Address review comments
natepage f357506
[Lock] Fix RedisStoreTestCase filename
natepage a0739ce
[Lock] Address review comments
natepage ff40b91
[Lock] Create DynamoDB table in save if it doesn't exist
natepage 4f0a780
[Lock] Address review comments
natepage 37e9888
[Lock] Change $clientOrUrl to $clientOrDsn in DynamoDbStore
natepage 53118f2
[Lock] Fix review comments
natepage 102a490
[Lock] Rename abstract redis store test case
natepage be2ba6f
[Lock] Change symfony/lock dependency to 7.4 in composer.json
natepage File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
/Tests export-ignore | ||
/phpunit.xml.dist export-ignore | ||
/.git* export-ignore |
8 changes: 8 additions & 0 deletions
8
src/Symfony/Component/Lock/Bridge/DynamoDb/.github/PULL_REQUEST_TEMPLATE.md
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
20 changes: 20 additions & 0 deletions
20
src/Symfony/Component/Lock/Bridge/DynamoDb/.github/workflows/close-pull-request.yml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
vendor/ | ||
composer.lock | ||
phpunit.xml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
CHANGELOG | ||
========= | ||
|
||
7.3 | ||
natepage marked this conversation as resolved.
Show resolved
Hide resolved
|
||
--- | ||
|
||
* Add the bridge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
Copyright (c) 2025-present Fabien Potencier | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
in the Software without restriction, including without limitation the rights | ||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
copies of the Software, and to permit persons to whom the Software is furnished | ||
to do so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in all | ||
copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
THE SOFTWARE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
Amazon DynamoDB Lock | ||
==================== | ||
|
||
Provides Amazon DynamoDB integration for Symfony Lock. | ||
natepage marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Resources | ||
--------- | ||
|
||
* [Contributing](https://symfony.com/doc/current/contributing/index.html) | ||
* [Report issues](https://github.com/symfony/symfony/issues) and | ||
[send Pull Requests](https://github.com/symfony/symfony/pulls) | ||
in the [main Symfony repository](https://github.com/symfony/symfony) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.