[Lock][WIP] Fix exists logic

symfony · natepage · Apr 4, 2025 · Apr 9, 2025 · Apr 9, 2025 · Apr 9, 2025
commit 0b16e0fda6208e299bcda8eeb0f1dcacf6b4de95
@@ -115,7 +115,7 @@
                if (preg_match(';^dynamodb\.([^\.]++)\.amazonaws\.com$;', $params['host'], $matches)) {
                    $clientConfiguration['region'] = $matches[1];
                }
            } elseif (self::DEFAULT_OPTIONS['endpoint'] !== $options['endpoint'] ?? self::DEFAULT_OPTIONS['endpoint']) {
                $clientConfiguration['endpoint'] = $options['endpoint'];
            }

@@ -190,24 +190,16 @@

        // Item not found at all
        if ($item === []) {
-            \var_dump('Item not found');
-
            return false;
        }

        // We are not the owner
-        if (isset($item[$this->tokenAttr]) === false || $this->getUniqueToken($key) !== $item[$this->tokenAttr]->getS()) {
-            \var_dump('Not owner', ['item' => $item, 'token' => $this->getUniqueToken($key)]);
-
+        if (!isset($item[$this->tokenAttr]) || $this->getUniqueToken($key) !== $item[$this->tokenAttr]->getS()) {
            return false;
        }

        // If item is expired, consider it doesn't exist
-        $expired = isset($item[$this->expirationAttr]) && \microtime(true) >= $item[$this->expirationAttr]->getN();
-
-        \var_dump('Expired', ['item' => $item, 'expired' => $expired]);
-
-        return $expired;
+        return isset($item[$this->expirationAttr]) && ((float) $item[$this->expirationAttr]->getN()) > \microtime(true);
    }

    public function putOffExpiration(Key $key, float $ttl): void