symfony · nicolas-grekas · Feb 10, 2025 · Feb 8, 2025 · xabbuh · Feb 8, 2025
diff --git a/...Symfony/Component/Messenger/Tests/EventListener/SendFailedMessageForRetryListenerTest.php b/...Symfony/Component/Messenger/Tests/EventListener/SendFailedMessageForRetryListenerTest.php
@@ -20,6 +20,7 @@
 use Symfony\Component\Messenger\EventListener\SendFailedMessageForRetryListener;
 use Symfony\Component\Messenger\Exception\HandlerFailedException;
 use Symfony\Component\Messenger\Exception\RecoverableMessageHandlingException;
+use Symfony\Component\Messenger\Retry\MultiplierRetryStrategy;
 use Symfony\Component\Messenger\Retry\RetryStrategyInterface;
 use Symfony\Component\Messenger\Stamp\DelayStamp;
 use Symfony\Component\Messenger\Stamp\RedeliveryStamp;
@@ -56,7 +57,9 @@ public function testIsRetryableFalseCausesNoRetry()
        $sender->expects($this->never())->method('send');
        $sendersLocator = new Container();
        $sendersLocator->set('my_receiver', $sender);
-        $listener = new SendFailedMessageForRetryListener($sendersLocator, new Container());
+        $retryStrategyLocator = new Container();
+        $retryStrategyLocator->set('my_receiver', new MultiplierRetryStrategy(0));
+        $listener = new SendFailedMessageForRetryListener($sendersLocator, $retryStrategyLocator);

        $exception = new \Exception('no!');
        $envelope = new Envelope(new \stdClass());
-Original file line number
+Diff line change
@@ -20,6 +20,7 @@
     use Symfony\Component\Messenger\EventListener\SendFailedMessageForRetryListener;
     use Symfony\Component\Messenger\Exception\HandlerFailedException;
     use Symfony\Component\Messenger\Exception\RecoverableMessageHandlingException;
+    use Symfony\Component\Messenger\Retry\MultiplierRetryStrategy;
     use Symfony\Component\Messenger\Retry\RetryStrategyInterface;
     use Symfony\Component\Messenger\Stamp\DelayStamp;
     use Symfony\Component\Messenger\Stamp\RedeliveryStamp;
@@ -56,7 +57,9 @@ public function testIsRetryableFalseCausesNoRetry()
             $sender->expects($this->never())->method('send');
             $sendersLocator = new Container();
             $sendersLocator->set('my_receiver', $sender);
-            $listener = new SendFailedMessageForRetryListener($sendersLocator, new Container());
+            $retryStrategyLocator = new Container();
+            $retryStrategyLocator->set('my_receiver', new MultiplierRetryStrategy(0));
+            $listener = new SendFailedMessageForRetryListener($sendersLocator, $retryStrategyLocator);
             Copy link

  
      
    
  

  
      

  
  Member


      

  Author


  

  
    
      

      
            xabbuh
  

      

      

      


        Feb 8, 2025


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      without this change we would only test that a message is not retried when no retry strategy can be found (but that's already tested in the previous testNoRetryStrategyCausesNoRetry() method)
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    

    



  
        
  
    
        
    
  


      
          
  
      
            Copy link

  
      
    
  

  
      

  
  Member


      

  

  
    
      

      
            alexandre-daubois
  

      

      

      


        Feb 9, 2025


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      No assert needs to be updated/added? Feels like the test is brittle if this was missing and nothing else needs an update
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
             $exception = new \Exception('no!');
             $envelope = new Envelope(new \stdClass());
-          Expand Down