[Messenger] add missing retry strategy #59736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Feb 8, 2025
| Q | A |
|---|---|
| Branch? | 7.3 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
xabbuh
commented
Feb 8, 2025
| $listener = new SendFailedMessageForRetryListener($sendersLocator, new Container()); | ||
| $retryStrategyLocator = new Container(); | ||
| $retryStrategyLocator->set('my_receiver', new MultiplierRetryStrategy(0)); | ||
| $listener = new SendFailedMessageForRetryListener($sendersLocator, $retryStrategyLocator); |
There was a problem hiding this comment.
without this change we would only test that a message is not retried when no retry strategy can be found (but that's already tested in the previous testNoRetryStrategyCausesNoRetry() method)
There was a problem hiding this comment.
No assert needs to be updated/added? Feels like the test is brittle if this was missing and nothing else needs an update
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.