[Filesystem] Change the picture used in a flaky tests #54472
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smnandre
reviewed
Apr 3, 2024
| @@ -170,7 +170,7 @@ public function testCopyForOriginUrlsAndExistingLocalFileDefaultsToCopy() | ||
| if (!\in_array('https', stream_get_wrappers())) { | ||
| $this->markTestSkipped('"https" stream wrapper is not enabled.'); | ||
| } | ||
| $sourceFilePath = 'https://symfony.com/images/common/logo/logo_symfony_header.png'; | ||
| $sourceFilePath = 'https://symfony.com/logos/symfony_black_02.png'; |
There was a problem hiding this comment.
Suggested change
| $sourceFilePath = 'https://symfony.com/logos/symfony_black_02.png'; | |
| $sourceFilePath = 'https://symfony.com/favicon.ico'; |
< 4ko, and this URL is 99.9% guaranteed to not change soon
🤷
(just a suggestion passing by :) )
|
see #54388 |
|
I was sure I saw something about it but couldn't find it. Thanks @xabbuh, seems way better like this 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a flaky test in the CI for a while now because of an image file.
I tried comparing pictures with https://www.robots.ox.ac.uk and found the following intriguing result:
I tried to compare the IDAT section of each PNG. They differ a bit, but nothing huge. But they differ, which cause the test to fail. After having a look for some time, I genuinely can't tell why is that. What I know for sure is that I've been able to reproduce it once, then I ran the test again and I couldn't reproduce it anymore. There's something with this logo that I can't understand. Or maybe some cache/CDN is involved?
I suggest using another picture (from https://symfony.com/logo) to avoid what happens with this precise picture. This will correct the flakiness of the test. The new picture is 8KB, the current one is 1.6KB which seems reasonable to me.