[Filesystem] use local PHP web server to test HTTP stream wrappers #54388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status: Needs work |
d574aa4 to
faa7089
Compare
fabpot
added a commit
that referenced
this pull request
Apr 1, 2024
…n (xabbuh) This PR was merged into the 5.4 branch. Discussion ---------- [HttpClient] stop all server processes after tests have run | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT spotted while working on #54388 Commits ------- 36345e0 stop all server processes after tests have run
ba5672f to
1434f89
Compare
|
Status: Needs Review |
stof
reviewed
Apr 1, 2024
| $process = new Process(array_merge([$finder->find(false)], $finder->findArguments(), ['-dopcache.enable=0', '-dvariables_order=EGPCS', '-S', '127.0.0.1:8057'])); | ||
| $process->setWorkingDirectory(__DIR__.'/Fixtures/web'); | ||
|
|
||
| $process->start(); |
There was a problem hiding this comment.
shouldn't we stop the process in a finally block to ensure it is properly closed ?
1434f89 to
dfa7677
Compare
nicolas-grekas
approved these changes
Apr 3, 2024
stof
approved these changes
Apr 3, 2024
dfa7677 to
8a7813b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same approach as #54360 (see https://github.com/symfony/symfony/actions/runs/8387183697/job/22968895866#step:8:2558 for a failure)