Fabbot.io error is unrelated https://fabbot.io/report/symfony/symfony/53668/f6d3c61717fd06c8a5380bc2afbde0fa7efae2ce

But I can fix it if wanted.

We shouldn't have made a difference between "null" and "unset". Is there a path toward this instead?
About the name: getStringOrNull (so that nobody has to wonder about what a "nullable string" is)
But I'd prefer not adding the methods, this API feels bloated...

We shouldn't have made a difference between "null" and "unset". Is there a path toward this instead?

It would require to change

    public function get(string $key, mixed $default = null): mixed
    {
        return \array_key_exists($key, $this->parameters) ? $this->parameters[$key] : $default;
    }

    public function has(string $key): bool
    {
        return \array_key_exists($key, $this->parameters);
    }

to

    public function get(string $key, mixed $default = null): mixed
    {
        return $this->parameters[$key] ?? $default;
    }

    public function has(string $key): bool
    {
        return isset($this->parameters[$key]);
    }

This would a BC-break, I don't know the impact.

The usage of array_key_exist seems here since SF2 with the commit d568437 from @fabpot.

I don't know why this behavior was preferred, but there are some tests about it @nicolas-grekas, like
https://github.com/symfony/symfony/blob/7.1/src/Symfony/Component/HttpFoundation/Tests/HeaderBagTest.php#L107-L108
so maybe it's important for headers (?)

About the name: getStringOrNull (so that nobody has to wonder about what a "nullable string" is)

I made the change.

The usage of array_key_exist seems here since SF2 with the commit d568437 from @fabpot.

This is the safest way to ensure a key in the array actual exists, because isset() works on the value and gives false when the key doesn't exist (unset) or is null.

The usage of array_key_exist seems here since SF2 with the commit d568437 from @fabpot.

This is the safest way to ensure a key in the array actual exists, because isset() works on the value and gives false when the key doesn't exist (unset) or is null.

Yes, but @nicolas-grekas said

We shouldn't have made a difference between "null" and "unset".

If Symfony doesn't want to make a difference between null and unset, the method isset should be preferred over array_key_exist.

Not sure about the status of this PR @nicolas-grekas @OskarStark, is there something I need to change ?

I answered #53668 (comment) and #53668 (comment) and was waiting about your feedback again :)