[HttpFoundation] Adds various return-typed getters to ParameterBag #49972
Conversation
mleczakm
commented
Apr 7, 2023
| Q | A |
|---|---|
| Branch? | 6.3 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | Fix #45775 |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
There was a problem hiding this comment.
Returning null as default or in case of invalid value are 2 distinct features. In 7.0, an exception will be thrown when the value is incompatible with the expected return type, one may prefer this behavior over returning null indistinctly.
Please check issues reported by fabbot.
|
|
||
| public function testGetIntOrNull(): void | ||
| { | ||
| $bag = new ParameterBag(['valid-value' => 1]); |
There was a problem hiding this comment.
An assertion with an invalid value is necessary, i.e. with a value that cannot be converted to int. Same for Boolean.
There was a problem hiding this comment.
I've changed it to using native getInt calls etc. so behaviour will be same in both cases.
src/Symfony/Component/HttpFoundation/Tests/ParameterBagTest.php
Outdated
Show resolved
Hide resolved
| @@ -155,6 +162,13 @@ public function getInt(string $key, int $default = 0): int | ||
| return $this->filter($key, $default, \FILTER_VALIDATE_INT, ['flags' => \FILTER_REQUIRE_SCALAR]) ?: 0; | ||
| } | ||
|
|
||
| public function getIntOrNull(string $key): ?int | ||
| { | ||
| return $this->has($key) |
There was a problem hiding this comment.
Checking if the value is set is not necessary:
filter_var(null, \FILTER_VALIDATE_INT, \FILTER_NULL_ON_FAILURE) returns null.
There was a problem hiding this comment.
I've changed it to use getInt implementation instead.