[DomCrawler] Allow to add choices to single select #53559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa4c796 to
a23a708
Compare
stof
reviewed
Jan 17, 2024
| @@ -110,6 +110,18 @@ public function testSelects() | ||
| } catch (\InvalidArgumentException $e) { | ||
| $this->assertTrue(true, '->setValue() throws an \InvalidArgumentException if the value is an array'); | ||
| } | ||
|
|
||
| $option = $this->createNode('option', 'Hello World', ['value' => 'hello_world']); |
There was a problem hiding this comment.
Please create a separate test instead of adding more things in the same test. This provides a much better experience:
- we have a test name telling us what this is about
- the status of the test is separate, giving us better failures
Existing dom-crawler tests are not following the testing best practices because this is one of the oldest components of Symfony, at a time where the usage of phpunit in Symfony was still quite new.
|
As this method is |
What would you suggest then? Can we remove |
smnandre
reviewed
Jan 17, 2024
| @@ -143,14 +143,14 @@ public function setValue(string|array|bool|null $value): void | ||
| */ | ||
| public function addChoice(\DOMElement $node): void | ||
| { | ||
| if (!$this->multiple && 'radio' !== $this->type) { | ||
| if (!$this->multiple && ('radio' !== $this->type && 'select' !== $this->type)) { | ||
| throw new \LogicException(sprintf('Unable to add a choice for "%s" as it is not multiple or is not a radio button.', $this->name)); |
smnandre
reviewed
Jan 17, 2024
| throw new \LogicException(sprintf('Unable to add a choice for "%s" as it is not multiple or is not a radio button.', $this->name)); | ||
| } | ||
|
|
||
| $option = $this->buildOptionValue($node); | ||
| $this->options[] = $option; | ||
|
|
||
| if ($node->hasAttribute('checked')) { | ||
| if ($node->hasAttribute('checked') || $node->hasAttribute('selected')) { |
There was a problem hiding this comment.
type === "radio" a&& attribute checked || type === select && attribute selected ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this was designed this way, but when using JS autocomplete's we cannot simulate it's behavior with a select element when a new choice was added to the list
cc @yceruto 🙏