Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[DomCrawler] impossible to test a value out of the options in ChoiceFormField #47642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 7.3
Choose a base branch
Loading
from
Open

[DomCrawler] impossible to test a value out of the options in ChoiceFormField #47642

wants to merge 1 commit into from
+0 −2

Conversation

jorissae
Copy link
Contributor

@jorissae jorissae commented Sep 21, 2022 •
edited
Loading

Q A
Branch? 6.2
Bug fix? No
New feature? No
Deprecations? No
Tickets >
License MIT
Doc PR

I couldn't test a value outside of the ChoiceForm field option nodes.
For example, even if my combobox does not offer the empty field, I want to test my NotBlank validator.

<?php
$form = $crawler->selectButton('ea[newForm][btn]')->form();
$client->submit($form, [
    'Item[vat]' => ''
]);

in Symfony\Component\BrowserKit\AbstractBrowser::submit ($client->submit())

public function submit(Form $form, array $values = [], array $serverParameters = []): Crawler
{
        $form->setValues($values);

        return $this->request($form->getMethod(), $form->getUri(), $form->getPhpValues(), $form->getPhpFiles(), $serverParameters);
}

InvalidArgumentException: Input "Item[vat]" cannot take "" as a value (possible values: "0", "700", "1900").

maybe there is another solution ? (like add arguments bool $throw = true to setValues or another ...)

Thanks

@carsonbot carsonbot added this to the 6.2 milestone Sep 21, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title impossible to test a value out of the options in ChoiceFormField [DomCrawler] impossible to test a value out of the options in ChoiceFormField Sep 21, 2022
@carsonbot
Copy link

Hey!

I think @localheinz has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@nicolas-grekas nicolas-grekas modified the milestones: 6.2, 6.3 Nov 5, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.4 May 23, 2023
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.1 Nov 15, 2023
@norkunas
Copy link
Contributor

norkunas commented Dec 7, 2023

Does nobody test autocomplete fields? 😅
Would be great addition.

@norkunas norkunas mentioned this pull request Dec 13, 2023
Open
@yceruto
Copy link
Member

yceruto commented Dec 13, 2023

If the option doesn't exist is because it's added dynamically via Javascript, so you'll need to simulate that behavior by using ChoiceFormField::addChoice($node) method before submit.

I don't think we should remove the validation check.

@norkunas norkunas mentioned this pull request Jan 17, 2024
Open
@xabbuh xabbuh modified the milestones: 7.1, 7.2 May 15, 2024
@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DomCrawler Feature Status: Needs Review
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
7 participants
@jorissae @carsonbot @norkunas @yceruto @fabpot @nicolas-grekas @xabbuh
Morty Proxy This is a proxified and sanitized view of the page, visit original site.