[Notifier] Add Pusher.com bridge #53267
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: remove @internal annotation from tests chore: add footer to README.md chore: apply PR comments
feat: configure pusher notifier on framework bundle
fix: drop sensitive information from toString method on transport
f034b8b to
974c996
Compare
|
I have mixed feelings about this bridge, code looks OK now after some fixes, but injecting the build client feels weird. In other bridges we do not depend on third party libraries. If someone want to take over and need this bridge, feels free to use this PR as a starting point. Closing here |
|
I haven't read the code but we don't want bridges that "just" wrap other clients. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #48203 because
Allow edits from Maintainerbox is unchecked