Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Notifier] Add Pusher Notifier Bridge #48203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 23 commits into from
Closed

[Notifier] Add Pusher Notifier Bridge #48203

wants to merge 23 commits into from

Conversation

bitgandtter
Copy link
Contributor

@bitgandtter bitgandtter commented Nov 12, 2022 •
edited by OskarStark
Loading

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR

Add Pusher symfony notifier bridge

@carsonbot carsonbot added this to the 6.2 milestone Nov 12, 2022
@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

OskarStark
OskarStark reviewed Nov 12, 2022
View reviewed changes
src/Symfony/Component/Notifier/Bridge/Pusher/CHANGELOG.md Outdated Show resolved Hide resolved
src/Symfony/Component/Notifier/Bridge/Pusher/.gitignore Outdated Show resolved Hide resolved
src/Symfony/Component/Notifier/Bridge/Pusher/LICENSE Outdated Show resolved Hide resolved
@OskarStark OskarStark removed this from the 6.2 milestone Nov 12, 2022
@bitgandtter
Copy link
Contributor Author

@OskarStark do I need to do something else?

@bitgandtter bitgandtter changed the title [Notifier] Add Pusher Notifier Bridge (WIP) [Notifier] Add Pusher Notifier Bridge Nov 15, 2022
OskarStark
OskarStark reviewed Dec 2, 2022
View reviewed changes
src/Symfony/Component/Notifier/Bridge/Pusher/CHANGELOG.md Outdated Show resolved Hide resolved
@bitgandtter
Copy link
Contributor Author

Hello. from fabpotbot

in Commits list, a git rebase is needed to remove any merges
Merge branch 'symfony:6.2' into pusher-notification
Merge branch 'symfony:6.3' into pusher-notification

excuse my ignorance what do I need to do with it?

thanks in advance

fabpot
fabpot reviewed Dec 3, 2022
View reviewed changes
src/Symfony/Component/Notifier/Bridge/Pusher/CHANGELOG.md Outdated Show resolved Hide resolved
@fabpot
Copy link
Member

fabpot commented Jan 8, 2023

To fix fabpot, you will need to rebase your PR instead of merging the base branch.
Here is the relevant section of the docs that explain it: https://symfony.com/doc/current/contributing/code/pull_requests.html#rebase-your-pull-request

@bitgandtter bitgandtter force-pushed the pusher-notification branch 2 times, most recently from 1755c72 to 11016ac Compare January 9, 2023 15:27
bitgandtter and others added 16 commits February 15, 2023 13:37
@bitgandtter
chore: apply fabbot
8c00bad
@bitgandtter
chore: work on PR comments
073986f
@bitgandtter
chore: drop declare strict types
8b701a7
@bitgandtter
chore: small format changes
c67f28a
@bitgandtter
fix: add pusher package to main composer.json to fix tests
dcd029f
@bitgandtter
chore: set PusherRecipientInterface as typehint of asPushMessage method
88bad27 
chore: remove @internal annotation from tests
chore: add footer to README.md
chore: apply PR comments
@bitgandtter
chore: set RecipientInterface as typehint of asPushMessage method
dee00b6
@derrabus @bitgandtter
Remove calls to AnnotationRegistry::registerLoader()
45ad1c6
@nicolas-grekas @bitgandtter
[PhpUnitBridge] Revert "minor symfony#48725 Remove calls to `Annotati…
6cd8b6e 
…onRegistry::registerLoader()`"
@derrabus @bitgandtter
Remove calls to AnnotationRegistry::registerLoader()
0d251c5
@nicolas-grekas @bitgandtter
[PhpUnitBridge] Revert "minor symfony#48725 Remove calls to `Annotati…
f7165d7 
…onRegistry::registerLoader()`"
@derrabus @bitgandtter
Remove calls to AnnotationRegistry::registerLoader()
a17252a
@bitgandtter
chore: fabbot
dc3e77d
@bitgandtter
fix: LICENSE
4771f05
@bitgandtter
chore: rebase for symfony#49385
60ec41e
@bitgandtter
chore: apply comments from symfony#49385
a4c4401
@bitgandtter
Copy link
Contributor Author

let me know if this works @nicolas-grekas

@bitgandtter
feat: drop autoconfigure tag from transport factory
7429e4d 
feat: configure pusher notifier on framework bundle
fabpot
fabpot requested changes Feb 16, 2023
View reviewed changes
src/Symfony/Component/Notifier/Bridge/Pusher/CHANGELOG.md Outdated Show resolved Hide resolved
src/Symfony/Component/Notifier/Bridge/Pusher/PusherTransport.php Outdated Show resolved Hide resolved
@bitgandtter
chore: drop extra - on CHANGELOG.md
2787214 
fix: drop sensitive information from toString method on transport
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.4 May 23, 2023
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.1 Nov 15, 2023
@OskarStark OskarStark mentioned this pull request Dec 28, 2023
Closed
@OskarStark
Copy link
Contributor

Replaced by

@OskarStark OskarStark closed this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot requested changes

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@xabbuh xabbuh Awaiting requested review from xabbuh

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

Assignees
No one assigned
Labels
Feature Notifier Status: Needs Work
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
7 participants
@bitgandtter @carsonbot @fabpot @nicolas-grekas @OskarStark @stof @derrabus
Morty Proxy This is a proxified and sanitized view of the page, visit original site.