[Translation] Remove @internal from abstract testcases
#52765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welcoMattic
approved these changes
Nov 27, 2023
|
Shouldn't most properties become private (as they have getters anyway) ? |
ping @nicolas-grekas because #40911 (comment) 😉 |
Do they currently? Do we use these classes cross components/providers? |
Yes the providers we have are using these test cases, or what do you mean? |
|
Thank you @OskarStark. |
nicolas-grekas
approved these changes
Nov 29, 2023
fabpot
approved these changes
Nov 29, 2023
|
Thank you @OskarStark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test cases are in the
Testnamespace and therefore under BC promise.All third-party providers should benefit from it.
We do the same for Mailer and Notifier.
cc @m2mtech as this PR is inspired by your comment in the copied class 😃 in
https://github.com/m2mtech/weblate-translation-provider/blob/fa38b3c50b5db832e993a0035f516ee0885482b1/tests/ProviderFactoryTestCase.php#L1-L5
@nicolas-grekas or do you want me to target
5.4?