[Translation] Move ProviderTestCase out of the Tests namespace #40911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's make the class internal? |
f1faf7a to
c1ec38f
Compare
✅ |
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 22, 2021
…sts namespace (derrabus) This PR was merged into the 5.3-dev branch. Discussion ---------- [Translation] Move ProviderFactoryTestCase out of the Tests namespace | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Same as #40911, different class. Sorry, I missed the seconds abstract class. 🙈 Commits ------- e01499d [Translation] Move ProviderFactoryTestCase out of the Tests namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
Testsnamespace is stripped from our distribution packages, the new Loco translation bridge cannot use the abstractProviderTestCaseclass. This PR suggests to move it into a dedicatedTestnamespace to make it reusable for the Loco bridge and potential future bridges.