Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[WebProfilerBundle] Replace last "old" icon + delete ICONS_LICENCE.txt #51621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

smnandre
Copy link
Member

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
License MIT

Two (related) things in this PR

  • replace two icons used in the Messenger profiler panel with a Tabler-Icon one (following the conventions used since the profiler redesign )
  • delete the now outdated ICONS_LICENCE.txt file (as there is no concerned icons remaining, and there is now a LICENCE.txt file in the Resources/views/Icon/ directory)

I targeted the 6.4 branch as there is no BC in code.. but i don't know how to handle a licence change 🤷🏻‍♂️


Previous icons After this PR
previous-icons tabler-icon

@javiereguiluz
Copy link
Member

Simon, thanks for this improvement. I like it!

About the removal of the previous icon license, I'd say there's no problem.


While reviewing this, I found two other occurrences of toggle-button in the form panel:

{% if data.children is not empty %}
<a class="toggle-button" data-toggle-target-id="{{ data.id }}-children" href="#"><span class="toggle-icon"></span></a>
{% else %}

<a class="toggle-button" data-toggle-target-id="{{ data.id }}-errors" href="#">
Errors <span class="toggle-icon"></span>
</a>

Would you have some time to try to update those too? If you can't, we can tackle that in another PR. Thanks.

@smnandre
Copy link
Member Author

While reviewing this, I found two other occurrences of toggle-button in the form panel:

That's not the same icon: it uses a "Tabler icon but in base64" .. would you like to change it for a "chevron" ?

(i rather ask if you did not see)

@javiereguiluz
Copy link
Member

@smnandre I didn't realize they were different icons. Sorry.

In any case, we should probably be consistent and use a chevron in all examples related to expand/collapse elements. Another thing; the current icon in form seem to NOT be working because I always see the [+], no matter if it's expanded or collapsed. So, maybe leave it for another PR?

@smnandre
Copy link
Member Author

@smnandre I didn't realize they were different icons. Sorry.

Don't be @javiereguiluz , i missed it entirely so .. :)

Works for me to leave the rest for another PR.. i'm feeling we may raise other questions / needs.

@fabpot
Copy link
Member

fabpot commented Sep 12, 2023

Thank you @smnandre.

@fabpot fabpot merged commit 4857210 into symfony:6.4 Sep 12, 2023
@fabpot fabpot force-pushed the dx/clean-webprofiler-icons branch from 999087a to 584c512 Compare September 12, 2023 06:01
fabpot added a commit that referenced this pull request Sep 13, 2023
This PR was merged into the 6.4 branch.

Discussion
----------

[WebProfilerBundle] Fix Form profiler toggles

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix
| License       | MIT

Following: #51621

* Reuse the chervron in the filetree
* Remove the not-togglin-toggle present on the error zone

| before | after
| - | - |
![before](https://github.com/symfony/symfony/assets/1359581/da92dba8-9b51-451d-8e58-7b78ceec848c)  | ![after](https://github.com/symfony/symfony/assets/1359581/21fdd60d-100b-4ee5-b611-5ccdef469210) |

Commits
-------

0dbab84 Fix Form profiler toggles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.