Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Security] Remove BC layer for HttpFoundation < 6.2 #50827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Jun 29, 2023

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR n/a

In #45034, a condition was added to support symfony/http-foundation < 6.2 or use the new Request::getContentTypeFormat() method when it exists.

I propose to update the minimum version of symfony/http-foundation required by symfony/security-http: 6.4.
symfony/security-http: 6.4 already requires symfony/http-kernel: ^6.3|^7.0 which require symfony/http-foundation: ^6.2.7

The legacy method Request::getContentType() will be removed in 7.0 by #50826

@GromNaN GromNaN added this to the 6.4 milestone Jun 29, 2023
@GromNaN GromNaN requested review from wouterj and chalasr as code owners June 29, 2023 23:48
@GromNaN GromNaN force-pushed the 6.4-authenticator-format branch from 58d42ec to 746c3fd Compare June 29, 2023 23:58
@GromNaN GromNaN changed the title [Security] Remove BC layer for HttpFoundation < 6.1 [Security] Remove BC layer for HttpFoundation < 6.2 Jun 29, 2023
@GromNaN
Copy link
Member Author

GromNaN commented Jun 30, 2023

The description of #45034 was incorrect. The feature was merged into 6.2.

I updated the requirement to ^6.2. That doesn't change anything given the existing transitive dependency to symfony/http-foundation: ^6.2.7.

@nicolas-grekas
Copy link
Member

Thank you @GromNaN.

@nicolas-grekas nicolas-grekas merged commit 80b5ef8 into symfony:6.4 Jun 30, 2023
@GromNaN GromNaN deleted the 6.4-authenticator-format branch June 30, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.