Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[HttpFoundation] Remove deprecated classes, method and behaviors #50826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Jun 29, 2023

Q A
Branch? 7.0
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR n/a

Clean symfony/http-foundation from all its legacy.

@GromNaN GromNaN requested a review from nicolas-grekas June 29, 2023 23:24
@carsonbot carsonbot added this to the 7.0 milestone Jun 29, 2023
@carsonbot carsonbot changed the title [HttpFoundation] Remove deprecated classes, method and behaviors [HttpFoundation] Remove deprecated classes, method and behaviors Jun 29, 2023
@GromNaN GromNaN force-pushed the http-foundation-7-deprecated branch from fa96e30 to 399fd1f Compare June 29, 2023 23:32
@GromNaN GromNaN force-pushed the http-foundation-7-deprecated branch 2 times, most recently from 0c58c33 to 8267a14 Compare June 30, 2023 00:30
nicolas-grekas added a commit that referenced this pull request Jun 30, 2023
…mNaN)

This PR was merged into the 6.4 branch.

Discussion
----------

[Security] Remove BC layer for HttpFoundation < 6.2

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | n/a

In #45034, a condition was added to support `symfony/http-foundation < 6.2` or use the new `Request::getContentTypeFormat()` method when it exists.

I propose to update the minimum version of `symfony/http-foundation` required by `symfony/security-http: 6.4`.
`symfony/security-http: 6.4` already requires `symfony/http-kernel: ^6.3|^7.0` [which require](https://github.com/symfony/symfony/blob/6.3/src/Symfony/Component/HttpKernel/composer.json) `symfony/http-foundation: ^6.2.7`

The legacy method `Request::getContentType()` will be removed in 7.0 by #50826

Commits
-------

746c3fd Remove BC layer for HttpFoundation < 6.1
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things and GTM, thanks.

UPGRADE-7.0.md Outdated Show resolved Hide resolved
src/Symfony/Component/HttpFoundation/CHANGELOG.md Outdated Show resolved Hide resolved
UPGRADE-7.0.md Outdated Show resolved Hide resolved
@GromNaN
Copy link
Member Author

GromNaN commented Jun 30, 2023

All changes done. Thanks for the review.

@GromNaN GromNaN force-pushed the http-foundation-7-deprecated branch from 45bd3ac to 2f74755 Compare June 30, 2023 11:53
@nicolas-grekas nicolas-grekas force-pushed the http-foundation-7-deprecated branch from 2f74755 to 665a775 Compare June 30, 2023 16:16
@nicolas-grekas
Copy link
Member

Thank you @GromNaN.

trigger_deprecation('symfony/http-foundation', '6.3', 'Ignoring invalid values when using "%s::%s(\'%s\')" is deprecated and will throw a "%s" in 7.0; '.$hint.' flag "FILTER_NULL_ON_FAILURE" to keep ignoring them.', $this::class, $method, $key, BadRequestException::class);

return false;
throw new BadRequestException(sprintf('Input value "%s" is invalid and flag "FILTER_NULL_ON_FAILURE" was not set.', $key));
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the message a bit to hint about the flag.

@GromNaN GromNaN deleted the http-foundation-7-deprecated branch June 30, 2023 18:02
@fabpot fabpot mentioned this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.